[Kde-games-devel] Faster KGameThemeSelector startup

Mauricio Piacentini mauricio at tabuleiro.com
Fri Jun 1 14:53:35 CEST 2007


Matt Williams wrote:
> I agree that the full check on the SVG isn't necessary, there _shouldn't_
> ever be any problem with loading the file anyway as long as it exists. The
> patch looks perfect. Maybe a note should be added to the API docs saying
> that though the theme could be loaded, no check on the SVG file contents
> was made so the user should check it themselves? Commit away as far as I'm
> concerned. Maraucio, what do you think?

I think it is ok, although it will not immediately catch problems with 
corrupted SVG files. But the application can then use KGameTheme->load 
for this.

Regards,
Mauricio


More information about the kde-games-devel mailing list