[Kde-games-devel] [Patch] Automatically fills in the user name in the high score dialogue.

[Albert Astals Cid]

A Diumenge 23 Desembre 2007, David Edmundson va escriure:
> When playing KNetwalk I found having to enter my name each time quite
> annoying.
>
> Attached is a patch that populates the edit box with the user's name from
> their account details. It still allows the user to edit before saving.This
> affects the highscore dialogue for all games.
>
> I don't have SVN access, as I'm still fairly new to the whole KDE
> development experience, so I've attached the patch needed for
> kscoredialog.cpp which someone in charge can decide wether to accept and
> submit it.

Hi David, thanks for the patch, a few comments below:
 * You are a bit late, we are in feature freeze and i doubt this can be 
considered a bugfix so unfortunately this will have to wait for KDE 4.1
 * It would be cool if you could improve the patch to have this behaviour:
   - Always use the last used name
   - If last used name get the name from KUser::FullName
 * KUser user= KUser(); should be really only be KUser user;
 * Watch out the style:
   - You are using tabs while the original file uses spaces. 
   - Your = spacing is inconsistent with itself (different in two different 
places) and different with the one used in the original file
   - As a general rule for KDE always follow the style of the file you are 
editing.
   - Also you added an empty line before the connect that seems to be non 
needed

Thanks and welcome to the KDE world :-)

Albert