[Kde-games-devel] Oware

Sat Jul 30 23:48:09 CEST 2005

Okay, I've fixed some of these things. I will address the other
comments/suggestions one-by-one.

> I've downloaded it, here are some comments
>  1 - Starting ./kde-oware-1.0.10 and clicking redo does something, it
> should
> not as obviously i've not undone anything.

Cool. Thanks. Fixed.

>  2 - Help should use standard kde help

Got a quick link where I can find out how to do that?

>  3 - There are lots of texts without i18n for example
>     QLabel* aml = new QLabel(QString(" SET WIZARD INTELLECT "),this);

These are defined away to i18n at the beginning of the file if compiling
for KDE. Qt doesn't have i18n, so I needed this hack to maintain compat
with KDE and Qt.

>  4 - Using qmake is not the standard kde build system, you need to use
> automake as everyone else does

I know. I thought you guys might have some special KDE standard automakes
that I'm required to use, so I put it off until I commit the source.

>  5 - The game is not installable, this has to be fixed as everything in
> kde
> has to be installable, when you make the game installable things like
> "imgs/owareicon16x16.png" are not going to work so you have to use
> locate()
> for that

Thanks. I'm looking into that.

>  6 - The "employment thing" is not going to be accepted

Removed.

>  7 - There is some text cut on "Your Score" in my computer, image
> attached.

Thanks. Implemented QFontMetrics.

>  8 - I don't see why you have to change user's default font to "arial" for
> drawing some texts

I wanted to enforce my stylistic vision of the game. That was important to
me.

>  9 - Using images with "HELP", etc embedded is not going to be accepted,
> as
> that is not translatable.

That's okay because everything is available in i18n from the standard menu
items. Those extra buttons are just for show. They also happen to work.:)

The extra buttons are pure and simple fun because they're African masks.
And games are better when they're fun. Lets leave 'em.

>  10 - There are memory leaks on the code, or at least that is what
> valgrind
> tells me.

Tell Valgrind that if he crashes Oware because of memory over consumption,
I'll send him a six of Budweiser wherever he is in the world.;)

If it leaks, I can't tell. I don't think it does, but I'm open to the
possibility. However, even if it does, users playing even 100 or more
games will not notice any appreciable additional memory consumption. I
mean, it's a game, not a server.

>  11 - If i remember correctly, all files inside KDE must have the license
> in
> the header of the file, so you should add it to all .cpp .c .h

Cool. Will do.

> Though you have some problems to be fixed the game can be imported into
> kde
> SVN. Not directly in kdegames but in playground/games so you can make it
> evolve there and when it's mature enough, that is, all the problems i
> comment
> above + some more things we can find, it can be moved to kdegames.
>
> Also, you have to understand that moving a program into KDE is very
> different
> from developing alone, for examples, texts like SET WIZARD INTELLECT will
> be
> lowercased because the Human Interface Guidelines do not allow all
> uppercase
> texts, etc.

Ah. Interesting. I will change texts to use mixed upper and lower.

> Also if you want to be inside KDE i'd suggest to completely drop the Qt
> only
> support, as it will fill your code with #if #else #endif things

I got some conflicting advice on this point from other list members, but I
think that's reasonable. I'll could try to make the source KDE-only,
though I don't want to exclude Qt'ers.

> I can help you with "ugly" things like automake, using standard kde help,
> etc.
> if you feel lost.

That would be great because I find KDE docs rather cryptic. Got any
suggestions on the help system?

> The first thing you need to do if you are sure you want oware to be moved
> inside playground/games is ask for a SVN account
> http://developer.kde.org/documentation/misc/applysvnaccount.php
> and then import the sources, if you feel you prefer someone else does the
> importing i can handle it for you.

Cool. Thanks for the suggestions. I'm looking forward to working with you
guys to put on the finishing touches!

Best,
Michael

> Albert
>
> A Dimecres 13 Juliol 2005 14:49, michaelcollins at ivorycity.com va escriure:
>> Has anyone had time to review my changes to the Oware Wizard? Version
>> 1.0.10 is now available on my site. It should be nearly ready, if not
>> ready, to add to CVS. Thanks! Michael
>>
>> http://oware.ivorycity.com
>>
>>
>> _______________________________________________
>> kde-games-devel mailing list
>> kde-games-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/kde-games-devel
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel
>