[kde-freebsd] turning threads off in OpenEXR by default

Mikhail Teterin mi+kde at aldan.algebra.com
Sun Oct 7 23:39:50 CEST 2007


On неділя 07 жовтень 2007, Norikatsu Shigemura wrote:
=        Thank you.  I merged your port.

I saw the change. I thought, the new ilmbase would belong to the devel/, 
rather than the graphics/ section -- it has nothing to do with graphics, 
really :-)

A more serious issue is your decision against running vendor's self-tests by 
default. Yes, I can see, that you left the test-target in the Makefile, but 
it should be used every time the package is built. The authors make some 
assumptions in their code, which may not always hold true -- for example, 
that sizeof(float) == sizeof(int) == 4 bytes.

Catching any breakage early is a very good thing...

Running the tests in a sub-shell (inside parens) is somewhat wasteful.

Thanks for resolving this anyway.

Yours,

	-mi


More information about the kde-freebsd mailing list