D28128: Add force save behavior to KEntryMap

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> bport wrote in kconfigtest.cpp:1970
> This is a global local file, not system wide and so not considered as default
> cf. https://lxr.kde.org/source/frameworks/kconfig/src/core/kconfig.cpp#0702
> if the entry is set system wide 
> /etc/kde5rc
> /etc/xdg/system.kdeglobals
> /etc/xdg/kdeglobals
> /etc/xdg/yourcustomfile
> ~/.config/system.kdeglobals
> 
> It will be reverted to the default value specified in the file

Oh I see.

~/.config/kdeglobals is still stuff that was set by the user, as opposed to system-wide settings that the user cannot modify.

> kconfigini.cpp:432
>          if (it->bGlobal == bGlobal) {
> -            if (it->bReverted) {
> +            if (it->bReverted && !it->bForceSave) {
>                  writeMap.remove(key);

Wouldn't it be enough to ensure that bReverted is false?
This would make for a much more minimal patch....

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200324/03a9339f/attachment.html>