<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28128">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28128#inline-160451">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bport</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kconfigtest.cpp:1970</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">This is a global local file, not system wide and so not considered as default<br />
cf. <a href="https://lxr.kde.org/source/frameworks/kconfig/src/core/kconfig.cpp#0702" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/frameworks/kconfig/src/core/kconfig.cpp#0702</a><br />
if the entry is set system wide <br />
/etc/kde5rc<br />
/etc/xdg/system.kdeglobals<br />
/etc/xdg/kdeglobals<br />
/etc/xdg/yourcustomfile<br />
~/.config/system.kdeglobals</p>
<p style="padding: 0; margin: 8px;">It will be reverted to the default value specified in the file</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Oh I see.</p>
<p style="padding: 0; margin: 8px;">~/.config/kdeglobals is still stuff that was set by the user, as opposed to system-wide settings that the user cannot modify.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28128#inline-160573">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kconfigini.cpp:432</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">it</span><span style="color: #aa2211">-></span><span class="n">bGlobal</span> <span style="color: #aa2211">==</span> <span class="n">bGlobal</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">it</span><span style="color: #aa2211">-></span><span class="n">bReverted</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">it</span><span style="color: #aa2211">-></span><span class="n">bReverted<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">!</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">bForceSave</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">writeMap</span><span class="p">.</span><span class="n">remove</span><span class="p">(</span><span class="n">key</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Wouldn't it be enough to ensure that bReverted is false?<br />
This would make for a much more minimal patch....</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R237 KConfig</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28128">https://phabricator.kde.org/D28128</a></div></div><br /><div><strong>To: </strong>bport, ervin, dfaure, meven, crossi, hchain<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>