D26600: Refator fstab handling
David Hallas
noreply at phabricator.kde.org
Sun Jan 12 07:44:01 GMT 2020
hallas created this revision.
hallas added reviewers: Frameworks, bruns, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.
REVISION SUMMARY
Refactor fstab handling
Splits the fstab/mtab handling code into smaller pieces and allow unit
testing of each one. The reafacting allows us to use the various classes
individually, e.g. use the FilesystemTableParser for parsing any
fstab/mtab style file.
This refactoring is a prerequisite for adding proper support for
fuseiso, since fuseiso maintains it's own mtab file, which we would like
to parse and use.
TEST PLAN
Unit tests
Tested manually with Plasma Vaults
REPOSITORY
R245 Solid
BRANCH
fstabhandling_rewrite
REVISION DETAIL
https://phabricator.kde.org/D26600
AFFECTED FILES
autotests/CMakeLists.txt
autotests/filesystem_entry_test.cpp
autotests/filesystem_entry_test.h
autotests/filesystem_table_parser_test.cpp
autotests/filesystem_table_parser_test.h
autotests/system_filesystem_table_test.cpp
autotests/system_filesystem_table_test.h
src/solid/devices/backends/fstab/CMakeLists.txt
src/solid/devices/backends/fstab/call_system_command.cpp
src/solid/devices/backends/fstab/call_system_command.h
src/solid/devices/backends/fstab/filesystem_entry.cpp
src/solid/devices/backends/fstab/filesystem_entry.h
src/solid/devices/backends/fstab/filesystem_table_parser.cpp
src/solid/devices/backends/fstab/filesystem_table_parser.h
src/solid/devices/backends/fstab/filesystem_table_watcher.cpp
src/solid/devices/backends/fstab/filesystem_table_watcher.h
src/solid/devices/backends/fstab/fstabdevice.cpp
src/solid/devices/backends/fstab/fstabdevice.h
src/solid/devices/backends/fstab/fstabhandling.cpp
src/solid/devices/backends/fstab/fstabhandling.h
src/solid/devices/backends/fstab/fstabmanager.cpp
src/solid/devices/backends/fstab/fstabmanager.h
src/solid/devices/backends/fstab/fstabstorageaccess.cpp
src/solid/devices/backends/fstab/fstabstorageaccess.h
src/solid/devices/backends/fstab/fstabwatcher.cpp
src/solid/devices/backends/fstab/fstabwatcher.h
src/solid/devices/backends/fstab/system_filesystem_table.cpp
src/solid/devices/backends/fstab/system_filesystem_table.h
To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200112/178e383a/attachment.html>
More information about the Kde-frameworks-devel
mailing list