D26600: Refator fstab handling

[David Hallas]

hallas added a comment.


  @meven - I am a little unsure if I have broken the fix you have done in commit c97f0b2a3076731b35435f200bd09a22859f3e03 <https://phabricator.kde.org/R245:c97f0b2a3076731b35435f200bd09a22859f3e03> - could you please check?
  
  I have not tested with NFS or SMB mounts.
  
  Finally, I think this code could be moved to a more general library in KDE Frameworks, because it appears that we have this functionality in multiple places. We have at least a partial copy of this in solid/src/solid/devices/backends/hal and probably also other places.

INLINE COMMENTS

> call_system_command.cpp:1
> +/***************************************************************************
> + *   Copyright (C) 2019 by David Hallas <david at davidhallas.dk>             *

I think the Copyright notice needs to include the original authors of this function

> filesystem_table_parser.cpp:2
> +/***************************************************************************
> + *   Copyright (C) 2019 by David Hallas <david at davidhallas.dk>             *
> + *                                                                         *

I think the Copyright notice needs to include the original authors of this function

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26600

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200112/3f5f02f5/attachment-0001.html>