<table><tr><td style="">hallas created this revision.<br />hallas added reviewers: Frameworks, bruns, meven.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />hallas requested review of this revision.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26600">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Refactor fstab handling</p>

<p>Splits the fstab/mtab handling code into smaller pieces and allow unit<br />

testing of each one. The reafacting allows us to use the various classes<br />

individually, e.g. use the FilesystemTableParser for parsing any<br />

fstab/mtab style file.</p>

<p>This refactoring is a prerequisite for adding proper support for<br />

fuseiso, since fuseiso maintains it's own mtab file, which we would like<br />

to parse and use.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Unit tests<br />

Tested manually with Plasma Vaults</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>BRANCH</strong><div><div>fstabhandling_rewrite</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26600">https://phabricator.kde.org/D26600</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/CMakeLists.txt<br />

autotests/filesystem_entry_test.cpp<br />

autotests/filesystem_entry_test.h<br />

autotests/filesystem_table_parser_test.cpp<br />

autotests/filesystem_table_parser_test.h<br />

autotests/system_filesystem_table_test.cpp<br />

autotests/system_filesystem_table_test.h<br />

src/solid/devices/backends/fstab/CMakeLists.txt<br />

src/solid/devices/backends/fstab/call_system_command.cpp<br />

src/solid/devices/backends/fstab/call_system_command.h<br />

src/solid/devices/backends/fstab/filesystem_entry.cpp<br />

src/solid/devices/backends/fstab/filesystem_entry.h<br />

src/solid/devices/backends/fstab/filesystem_table_parser.cpp<br />

src/solid/devices/backends/fstab/filesystem_table_parser.h<br />

src/solid/devices/backends/fstab/filesystem_table_watcher.cpp<br />

src/solid/devices/backends/fstab/filesystem_table_watcher.h<br />

src/solid/devices/backends/fstab/fstabdevice.cpp<br />

src/solid/devices/backends/fstab/fstabdevice.h<br />

src/solid/devices/backends/fstab/fstabhandling.cpp<br />

src/solid/devices/backends/fstab/fstabhandling.h<br />

src/solid/devices/backends/fstab/fstabmanager.cpp<br />

src/solid/devices/backends/fstab/fstabmanager.h<br />

src/solid/devices/backends/fstab/fstabstorageaccess.cpp<br />

src/solid/devices/backends/fstab/fstabstorageaccess.h<br />

src/solid/devices/backends/fstab/fstabwatcher.cpp<br />

src/solid/devices/backends/fstab/fstabwatcher.h<br />

src/solid/devices/backends/fstab/system_filesystem_table.cpp<br />

src/solid/devices/backends/fstab/system_filesystem_table.h</div></div></div><br /><div><strong>To: </strong>hallas, Frameworks, bruns, meven<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>