D27148: update d->m_file in ReadOnlyPart::setUrl()

[Ahmad Samir]

ahmadsamir added a comment.


  IIUC, this diff is fixing https://bugs.kde.org/show_bug.cgi?id=416989 (Konqueror -> Tools -> open terminal, doesn't work after D26140 <https://phabricator.kde.org/D26140>).
  
  Looking at the code in dolphin/src/dolphinpart.cpp, openUrl() is reimplemented[1], and it does call ReadOnlyPart::setUrl(); how about checking if url is a local file and calling ReadOnlyPart::setLocalFilePath() in DolphinPart::openUrl()?
  
  [1] https://cgit.kde.org/dolphin.git/tree/src/dolphinpart.cpp#n300

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27148

To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure
Cc: ahmadsamir, marten, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200205/604711f3/attachment.html>