D27148: update d->m_file in ReadOnlyPart::setUrl()

Jonathan Marten noreply at phabricator.kde.org
Wed Feb 5 16:57:09 GMT 2020


marten added a comment.


  @ahmadsamir: Yes, the problem could be fixed in Dolphin, but that leaves a potential trap for any other KPart that reimplements openUrl().
  
  As a minimum, if it is decided that the fix belongs in the application then KParts::ReadOnlyPart should have a caution in the API documentation that localFilePath() will only return a valid result if openUrl() or setLocalFilePath() has previously been called.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27148

To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure
Cc: ahmadsamir, marten, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200205/bcc18960/attachment.html>


More information about the Kde-frameworks-devel mailing list