<table><tr><td style="">ahmadsamir added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27148">View Revision</a></tr></table><br /><div><div><p>IIUC, this diff is fixing <a href="https://bugs.kde.org/show_bug.cgi?id=416989" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=416989</a> (Konqueror -> Tools -> open terminal, doesn't work after <a href="https://phabricator.kde.org/D26140" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D26140</a>).</p>
<p>Looking at the code in dolphin/src/dolphinpart.cpp, openUrl() is reimplemented[1], and it does call ReadOnlyPart::setUrl(); how about checking if url is a local file and calling ReadOnlyPart::setLocalFilePath() in DolphinPart::openUrl()?</p>
<p>[1] <a href="https://cgit.kde.org/dolphin.git/tree/src/dolphinpart.cpp#n300" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/dolphin.git/tree/src/dolphinpart.cpp#n300</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R306 KParts</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27148">https://phabricator.kde.org/D27148</a></div></div><br /><div><strong>To: </strong>pdabrowski, elvisangelaccio, ngraham, Frameworks, dfaure<br /><strong>Cc: </strong>ahmadsamir, marten, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>