D23722: Warn if KPackage is invalid

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> apol wrote in configmodule.cpp:174
> maybe put it after checking the mainscript?  the "no QML file provided" error is more accurate. We can keep ::isValid as a fallback.
> Actually, if there's no mainscript it probably shouldn't be valid.

Is "mainscript" mandatory?

In any case, if your package has the incorrect folder structure, it previously printed "no QML file provided" which is super misleading as it suggests the config entry is missing which it usually isn't.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23722

To: broulik, mart, tcanabrava
Cc: apol, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190905/10939704/attachment.html>