D23722: Warn if KPackage is invalid

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> configmodule.cpp:174
> +
>      if (!package.filePath("mainscript").isEmpty()) {
>          d->_qmlObject->setSource(package.fileUrl("mainscript"));

maybe put it after checking the mainscript?  the "no QML file provided" error is more accurate. We can keep ::isValid as a fallback.
Actually, if there's no mainscript it probably shouldn't be valid.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23722

To: broulik, mart, tcanabrava
Cc: apol, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190905/0ec5411d/attachment.html>