D23722: Warn if KPackage is invalid

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Let's consider it an iteration though.

INLINE COMMENTS

> broulik wrote in configmodule.cpp:174
> Is "mainscript" mandatory?
> 
> In any case, if your package has the incorrect folder structure, it previously printed "no QML file provided" which is super misleading as it suggests the config entry is missing which it usually isn't.

¯\_(ツ)_/¯

If that's the case...

Maybe we could see to passing a string ref argument to isValid? Or adding a Package::errorString method (that will likely dupe all the logic).

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23722

To: broulik, mart, tcanabrava, apol
Cc: apol, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190905/215232bb/attachment-0001.html>