<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23722">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23722#inline-134083">View Inline</a><span style="color: #4b4d51; font-weight: bold;">configmodule.cpp:174</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">package</span><span class="p">.</span><span class="n">filePath</span><span class="p">(</span><span style="color: #766510">"mainscript"</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">_qmlObject</span><span style="color: #aa2211">-></span><span class="n">setSource</span><span class="p">(</span><span class="n">package</span><span class="p">.</span><span class="n">fileUrl</span><span class="p">(</span><span style="color: #766510">"mainscript"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">maybe put it after checking the mainscript?  the "no QML file provided" error is more accurate. We can keep ::isValid as a fallback.<br />
Actually, if there's no mainscript it probably shouldn't be valid.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 KDeclarative</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23722">https://phabricator.kde.org/D23722</a></div></div><br /><div><strong>To: </strong>broulik, mart, tcanabrava<br /><strong>Cc: </strong>apol, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns<br /></div>