D23801: Port kpac from QtScript

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> script.cpp:316
>  // @returns true if @p str matches the shell @p pattern
> -QScriptValue ShExpMatch(QScriptContext *context, QScriptEngine *engine)
> +Q_INVOKABLE QJSValue ShExpMatch(QString str, QString patternStr)
>  {

Hi @carewolf . Curious: Why all the non-const-ref QString argument types here?

Is there a need to do that with Q_INVOKABLE methods somehow?
Asking because clazy falgs these, compare D25039 <https://phabricator.kde.org/D25039>

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23801

To: carewolf, dfaure
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191030/a58b92b2/attachment-0001.html>