<table><tr><td style="">kossebau added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23801">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23801#inline-141561">View Inline</a><span style="color: #4b4d51; font-weight: bold;">script.cpp:316</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">// @returns true if @p str matches the shell @p pattern</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="n">Q<span class="bright">Script</span>Value</span> <span style="color: #004012">ShExpMatch</span><span class="p">(</span><span class="n">QS<span class="bright">criptContext</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">context</span></span><span class="p">,</span> <span class="n">QS<span class="bright">criptEngine</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">engine</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">Q<span class="bright">_INVOKABLE</span></span><span class="bright"> </span><span class="n"><span class="bright">QJS</span>Value</span> <span class="n">ShExpMatch</span><span class="p">(</span><span class="n">QS<span class="bright">tring</span></span><span class="bright"> </span><span class="n"><span class="bright">str</span></span><span class="p">,</span> <span class="n">QS<span class="bright">tring</span></span><span class="bright"> </span><span class="n"><span class="bright">patternStr</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hi <a href="https://phabricator.kde.org/p/carewolf/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@carewolf</a> . Curious: Why all the non-const-ref QString argument types here?</p>

<p style="padding: 0; margin: 8px;">Is there a need to do that with Q_INVOKABLE methods somehow?<br />
Asking because clazy falgs these, compare <a href="https://phabricator.kde.org/D25039" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D25039</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23801">https://phabricator.kde.org/D23801</a></div></div><br /><div><strong>To: </strong>carewolf, dfaure<br /><strong>Cc: </strong>kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>