D23801: Port kpac from QtScript

[Allan Sandfeld Jensen]

carewolf added inline comments.

INLINE COMMENTS

> kossebau wrote in script.cpp:316
> Hi @carewolf . Curious: Why all the non-const-ref QString argument types here?
> 
> Is there a need to do that with Q_INVOKABLE methods somehow?
> Asking because clazy falgs these, compare D25039 <https://phabricator.kde.org/D25039>

Not really. I prefer to do it that way for invokable as the value will be copied, but const ref works too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23801

To: carewolf, dfaure
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191031/b4375f64/attachment.html>