D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> dfaure wrote in CMakeLists.txt:49
> It does, but people can still pass -DCMAKE_BUILD_TYPE=Release, or RelWithDebInfo (as I do for profiling).
> 
> Won't this give them the warning below then, even if they don't set the KIO_ASSERT_SLAVE_STATES option)?
> 
> I would just set ASSERT_SLAVE_STATES_DEFAULT to OFF when the build type isn't Debug.
> (i.e. checking for that as part of the condition on line 42)

Well, at that point you can choose to:

- explicitly -DASSERT_SLAVE_STATES_DEFAULT=OFF which will not trigger the warning as the option will not default to the auto detection if you set it manually
- just ignore the warning

If you don't want that I'd actually get rid of the warning altogether. Determining what a given build type does isn't so reliably doable as users may have custom build types that define whatever, so the warning is more of a crutch than anything.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24827

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191022/b73fa04e/attachment-0001.html>