D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:49
>  if(KIO_ASSERT_SLAVE_STATES AND NOT CMAKE_BUILD_TYPE MATCHES "[Dd]ebug$")
> -    message(FATAL_ERROR "KIO_ASSERT_SLAVE_STATES option enabled but not a Debug build. This makes no sense!")
> +    # ECM_SOURCE_UNDER_VERSION_CONTROL also auto-enables Debug, so this
> +    # should generally not happen:

It does, but people can still pass -DCMAKE_BUILD_TYPE=Release, or RelWithDebInfo (as I do for profiling).

Won't this give them the warning below then, even if they don't set the KIO_ASSERT_SLAVE_STATES option)?

I would just set ASSERT_SLAVE_STATES_DEFAULT to OFF when the build type isn't Debug.
(i.e. checking for that as part of the condition on line 42)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24827

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191021/22c4a414/attachment.html>