D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

Harald Sitter noreply at phabricator.kde.org
Mon Oct 21 12:38:15 BST 2019


sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  testing high level functionality of a bunch of relevant slaves yielded no
  obvious problems, so let's enable slave state assertion for all builds from
  git repos now. this should give much wider testing coverage
  
  print a warning when having slave assertion but without debug build instead
  of a fatal error, outside CI that is a valid thing to do albeit still not
  making too much sense as we want people to have state assertion enabled

TEST PLAN
  cmake with .git enables the option, without it doesn't, with .git and type set to Release a warning is printed

REPOSITORY
  R241 KIO

BRANCH
  assert-for-git

REVISION DETAIL
  https://phabricator.kde.org/D24827

AFFECTED FILES
  CMakeLists.txt

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191021/caffc95c/attachment.html>


More information about the Kde-frameworks-devel mailing list