<table><tr><td style="">sitter created this revision.<br />sitter added a reviewer: dfaure.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />sitter requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24827">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>testing high level functionality of a bunch of relevant slaves yielded no<br />
obvious problems, so let's enable slave state assertion for all builds from<br />
git repos now. this should give much wider testing coverage</p>
<p>print a warning when having slave assertion but without debug build instead<br />
of a fatal error, outside CI that is a valid thing to do albeit still not<br />
making too much sense as we want people to have state assertion enabled</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>cmake with .git enables the option, without it doesn't, with .git and type set to Release a warning is printed</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>assert-for-git</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24827">https://phabricator.kde.org/D24827</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt</div></div></div><br /><div><strong>To: </strong>sitter, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>