D25443: [chmodjob] Port away from QLinkedList

[Stefan Brüns]

bruns added a comment.


  Or just change the direction?

INLINE COMMENTS

> chmodjob.cpp:115
>  {
>      Q_Q(ChmodJob);
>      while (!m_lstItems.isEmpty()) {

For efficiency, probably do a
`m_infos.reserve(m_infos.capacity() + m_lstItems.size());`
here.

> chmodjob.cpp:155
>      KIO::UDSEntryList::ConstIterator end = list.end();
>      for (; it != end; ++it) {
>          const KIO::UDSEntry &entry = *it;

For efficiency, probably do a
`m_infos.reserve(m_infos.capacity() + list.size());`
here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks
Cc: bruns, fabiank, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191121/5ad032f6/attachment.html>