<table><tr><td style="">bruns added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25443">View Revision</a></tr></table><br /><div><div><p>Or just change the direction?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25443#inline-143771">View Inline</a><span style="color: #4b4d51; font-weight: bold;">chmodjob.cpp:115</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Q_Q</span><span class="p">(</span><span class="n">ChmodJob</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">while</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_lstItems</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">For efficiency, probably do a<br />
<tt style="background: #ebebeb; font-size: 13px;">m_infos.reserve(m_infos.capacity() + m_lstItems.size());</tt><br />
here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25443#inline-143768">View Inline</a><span style="color: #4b4d51; font-weight: bold;">chmodjob.cpp:155</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntryList</span><span style="color: #aa2211">::</span><span class="n">ConstIterator</span> <span class="n">end</span> <span style="color: #aa2211">=</span> <span class="n">list</span><span class="p">.</span><span class="n">end</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">for</span> <span class="p">(;</span> <span class="n">it</span> <span style="color: #aa2211">!=</span> <span class="n">end</span><span class="p">;</span> <span style="color: #aa2211">++</span><span class="n">it</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">const</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span> <span style="color: #aa2211">&</span><span class="n">entry</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">*</span><span class="n">it</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">For efficiency, probably do a<br />
<tt style="background: #ebebeb; font-size: 13px;">m_infos.reserve(m_infos.capacity() + list.size());</tt><br />
here.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25443">https://phabricator.kde.org/D25443</a></div></div><br /><div><strong>To: </strong>nicolasfella, Frameworks<br /><strong>Cc: </strong>bruns, fabiank, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham<br /></div>