D25443: [chmodjob] Port away from QLinkedList

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> chmodjob.cpp:131
>                            << "\n new permissions = " << QString::number(info.permissions,8);*/
> -            m_infos.prepend(info);
> +            m_infos.push_front(info);
>              //qDebug() << "processList : Adding info for " << info.url;

This could even be `push_front(std::move(info))` since `info` isn't used anymore afterwards;

> chmodjob.cpp:190
>              // This way, the toplevel dirs are done last.
> -            m_infos.prepend(info);
> +            m_infos.push_front(info);
>          }

same here

> chmodjob.cpp:224
>                      case Result_Retry:
> -                        m_infos.prepend(info);
> +                        m_infos.push_front(info);
>                          QMetaObject::invokeMethod(q, "_k_chmodNextFile", Qt::QueuedConnection);

same here

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191121/d500d5eb/attachment-0001.html>