D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO
Alexander Saoutkin
noreply at phabricator.kde.org
Fri Nov 15 12:56:00 GMT 2019
feverfew added inline comments.
INLINE COMMENTS
> sitter wrote in krun.cpp:583
> Coding style says we use curly braces even for single-line if statements I think.
Yep you're right, will fix in a mo.
> sitter wrote in krun.cpp:598
> What I meant is you should literally iterate using
>
> for (QUrl &url : urls) {
>
> which is what the code did before but you changed it for some reason.
Yes, but note later I need to then change the values in the `QList` outside of the for loop, hence why I store the index in a struct associated with the reply. How would I do that easily with a range based for loop?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23384
To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191115/2c50b7cd/attachment.html>
More information about the Kde-frameworks-devel
mailing list