D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in deletejob.cpp:67
> Seems negligible to me. If you remove the argument, you'll have to "reconstruct" the URL from files.first()/symlinks.first()? Or [ab]use m_currentURL?
> The "no premature optimization" rule says: don't change it if the resulting code is going to be more complicated.

With my code change `m_currentUrl` is always equal to this `url` just before calling rmfile/rmdir so yes it would be about [ab]using m_currentURL.
So it adds an implicit invariant around m_currentURL that should be obvious to future maintainers IMO.
Is this reducing in message passing worth this added invariant ?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24962

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191102/f3a6b87a/attachment-0001.html>