D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

David Faure noreply at phabricator.kde.org
Sun Nov 3 12:35:23 GMT 2019


dfaure added inline comments.

INLINE COMMENTS

> deletejob.cpp:406
> +            QMetaObject::invokeMethod(worker(), "rmfile", Qt::QueuedConnection,
> +                                      Q_ARG(const QUrl&, m_currentURL),
> +                                      Q_ARG(bool, isLink));

Since you're already using m_currentURL here, I'd say this is acceptable.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24962

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191103/440f5186/attachment.html>


More information about the Kde-frameworks-devel mailing list