D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> meven wrote in deletejob.cpp:67
> I am hesitant to remove `const QUrl& url` from this signal, it could save some space in message passing.

Seems negligible to me. If you remove the argument, you'll have to "reconstruct" the URL from files.first()/symlinks.first()? Or [ab]use m_currentURL?
The "no premature optimization" rule says: don't change it if the resulting code is going to be more complicated.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24962

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191102/d522bd0f/attachment-0001.html>