D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 60052.
leinir marked 2 inline comments as done.
leinir added a comment.


  Address pino's comments about BIC (and some documentation)
  
  - Don't mark functions virtual which should not be virtual
  - Apply the signal/slot virt func workaround for improved BIC
  - Add a bit more documentation (and some @since)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60021&id=60052

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190619/d4fe997b/attachment.html>