D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir marked 2 inline comments as done.
leinir added inline comments.

INLINE COMMENTS

> pino wrote in engine.h:471
> BIC change, you cannot add virtual  functions in a public class

That shouldn't be virtual anyway, not sure why i did that...

> pino wrote in provider.h:148
> BIC change, you cannot add virtual  functions in a public class

That's a fair bit more annoying... Oh well, signal-based workaround it is, i guess (not like we have a lot of providers anyway ;) )

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190619/cff3fd0d/attachment-0001.html>