<table><tr><td style="">leinir updated this revision to Diff 60052.<br />leinir marked 2 inline comments as done.<br />leinir added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21721">View Revision</a></tr></table><br /><div><div><p>Address pino's comments about BIC (and some documentation)</p>

<ul class="remarkup-list">

<li class="remarkup-list-item">Don't mark functions virtual which should not be virtual</li>

<li class="remarkup-list-item">Apply the signal/slot virt func workaround for improved BIC</li>

<li class="remarkup-list-item">Add a bit more documentation (and some <span class="phabricator-remarkup-mention-unknown">@since</span>)</li>

</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D21721?vs=60021&id=60052">https://phabricator.kde.org/D21721?vs=60021&id=60052</a></div></div><br /><div><strong>BRANCH</strong><div><div>knsquick-feature-parity-with-kns (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21721">https://phabricator.kde.org/D21721</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/attica/atticaprovider.cpp<br />

src/attica/atticaprovider_p.h<br />

src/core/CMakeLists.txt<br />

src/core/commentsmodel.cpp<br />

src/core/commentsmodel.h<br />

src/core/engine.cpp<br />

src/core/engine.h<br />

src/core/entryinternal.cpp<br />

src/core/installation.cpp<br />

src/core/itemsmodel.cpp<br />

src/core/itemsmodel.h<br />

src/core/provider.h<br />

src/core/question.h<br />

src/qtquick/CMakeLists.txt<br />

src/qtquick/categoriesmodel.cpp<br />

src/qtquick/categoriesmodel.h<br />

src/qtquick/qml/ConditionalLoader.qml<br />

src/qtquick/qml/EntryCommentDelegate.qml<br />

src/qtquick/qml/EntryCommentsPage.qml<br />

src/qtquick/qml/EntryScreenshots.qml<br />

src/qtquick/qml/GridTileDelegate.qml<br />

src/qtquick/qml/NewStuffButton.qml<br />

src/qtquick/qml/NewStuffDialog.qml<br />

src/qtquick/qml/NewStuffDialogContent.qml<br />

src/qtquick/qml/NewStuffDownloadItemsSheet.qml<br />

src/qtquick/qml/NewStuffEntryDetails.qml<br />

src/qtquick/qml/NewStuffPage.qml<br />

src/qtquick/qml/NewStuffQuestionAsker.qml<br />

src/qtquick/qml/Rating.qml<br />

src/qtquick/qml/Shadow.qml<br />

src/qtquick/qmldir<br />

src/qtquick/qmlplugin.cpp<br />

src/qtquick/quickengine.cpp<br />

src/qtquick/quickengine.h<br />

src/qtquick/quickitemsmodel.cpp<br />

src/qtquick/quickitemsmodel.h<br />

src/qtquick/quickquestionlistener.cpp<br />

src/qtquick/quickquestionlistener.h<br />

tests/CMakeLists.txt<br />

tests/khotnewstuff-dialog-ui/main.qml<br />

tests/khotnewstuff-dialog.cpp</div></div></div><br /><div><strong>To: </strong>leinir<br /><strong>Cc: </strong>pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns<br /></div>