D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

Pino Toscano noreply at phabricator.kde.org
Tue Jun 18 15:21:10 BST 2019


pino added inline comments.

INLINE COMMENTS

> engine.h:471
> +     */
> +    virtual CommentsModel* commentsForEntry(const KNSCore::EntryInternal &entry);
> +

BIC change, you cannot add virtual  functions in a public class

> provider.h:148
>      virtual void loadPayloadLink(const EntryInternal &entry, int linkId) = 0;
> +    virtual void loadComments(const EntryInternal &, int, int) {};
>  

BIC change, you cannot add virtual  functions in a public class

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190618/1b748227/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list