D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Feb 12 15:47:18 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> poboiko wrote in kinotify.cpp:390
> I'm a bit lost, why is it a problem? Or do you mean it's a costly operation and suggest to do the following?
> 
>   const QString& fname = QFile::decodeName(path);
>   Q_EMIT created(fname);
>   [...]
>   handleDirCreated(fname);

yes, but just `const QString fname = ...`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190212/705647e6/attachment.html>


More information about the Kde-frameworks-devel mailing list