D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Igor Poboiko]

poboiko added inline comments.

INLINE COMMENTS

> bruns wrote in kinotify.cpp:390
> `QFile::decodeName(path)` twice ...

I'm a bit lost, why is it a problem? Or do you mean it's a costly operation and suggest to do the following?

  const QString& fname = QFile::decodeName(path);
  Q_EMIT created(fname);
  [...]
  handleDirCreated(fname);

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190212/dcc30bc2/attachment.html>