D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

Igor Poboiko noreply at phabricator.kde.org
Tue Feb 12 15:58:01 GMT 2019


poboiko added inline comments.

INLINE COMMENTS

> bruns wrote in kinotify.cpp:390
> yes, but just `const QString fname = ...`

Right, sorry, misprinted. 
Actually, since there are a lot of `decodeName` calls around, probably it would be better to decode it just once, right before `event->mask` matching then, and then pass it everywhere?
(less code duplication & mutliple calls if `mask` matches several events...)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190212/61757f7f/attachment.html>


More information about the Kde-frameworks-devel mailing list