D18907: Handle the case if createSpeller is passed an unavailable language

Ahmad Samir noreply at phabricator.kde.org
Sun Feb 10 19:04:46 GMT 2019


ahmadsamir created this revision.
ahmadsamir added reviewers: sandsmark, cullmann, dhaumann.
ahmadsamir added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  In Loader::createSpeller, retun early if lang isn't one of the available
  languages(); otherwise a dud entry will be created for it in
  dictionarycombobox.
  
  Emit a signal when loading a dictionary fails, so that Ui parts can
  display an appropriate error message informing the user about the issue,
  instead of failing silently.
  
  This is a first step to fix bug 325541.

REPOSITORY
  R246 Sonnet

BRANCH
  speller-loader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18907

AFFECTED FILES
  src/core/loader.cpp
  src/core/loader_p.h

To: ahmadsamir, sandsmark, cullmann, dhaumann
Cc: dhaumann, cullmann, loh.tar, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190210/e63e281b/attachment.html>


More information about the Kde-frameworks-devel mailing list