D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> dfaure wrote in kbookmarkowner.h:120
> Every version of KF5 is source and binary compatible (just like Qt5).
> The next time for a possible BC breakage will be KF6 (when Qt6 comes out), so not just yet.
> 
> Two alternative solutions:
> 
> - creating a KBookmarkOwnerV2 interface, deriving from KBookmarkOwner. This is a typical solution for extending interfaces, but it's somewhat cumbersome (ugly name, downcasting...).
> - adding a getter/setter to another class where it would make more sense, maybe KBookmarkMenu? Would the app that you have in mind, have access to it?

Ok, in that case I think we should definitely go with your first suggestion with getters/settings and maybe writing a note about refactoring it for KF6. I will cook it up and update the patch set, also including the changes to the unit test as you suggested :D

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190414/e280946d/attachment.html>