D20238: device: include Reapply() in the interface
Jan Grulich
noreply at phabricator.kde.org
Thu Apr 4 06:59:07 BST 2019
jgrulich added inline comments.
INLINE COMMENTS
> device.h:241
> + */
> + QDBusPendingReply<> reapplyInterface(NMVariantMapMap connection, qulonglong version_id, uint flags);
> /**
1. const NMVariantMapMap &connection
2. I would maybe pick a different name, because it doesn't reapply interface, but it reapplies or updates connection. I would maybe use "reapplyConnection()"
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D20238
To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190404/d2ee331a/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list