<table><tr><td style="">jgrulich added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20238">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20238#inline-113979">View Inline</a><span style="color: #4b4d51; font-weight: bold;">device.h:241</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QDBusPendingReply</span><span style="color: #aa2211"><></span> <span class="n">reapplyInterface</span><span class="p">(</span><span class="n">NMVariantMapMap</span> <span class="n">connection</span><span class="p">,</span> <span class="n">qulonglong</span> <span class="n">version_id</span><span class="p">,</span> <span class="n">uint</span> <span class="n">flags</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211">/**</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><ol class="remarkup-list">
<li class="remarkup-list-item">const NMVariantMapMap &connection</li>
</ol>
<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">I would maybe pick a different name, because it doesn't reapply interface, but it reapplies or updates connection. I would maybe use "reapplyConnection()"</li>
</ol></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R282 NetworkManagerQt</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20238">https://phabricator.kde.org/D20238</a></div></div><br /><div><strong>To: </strong>aleksanderm, jgrulich, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>