D20244: [AppletInterface] Check for corona before accessing it

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Apr 4 08:16:56 BST 2019


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  On plasmashell shutdown when the panels are destroyed, the available screen geometry changes.
  When an applet then accesses `screenGeometry` in response to that change, it crashes because the corona is already gone.
  
  `availableScreenRegion()` and `availableScreenRect()` already checked for this but `screenGeometry()` did not

TEST PLAN
  No longer have plasma crash in shutdown because of notification popup placement
  
  Ideally, plasmashell didn't bother signalling those changes on shutdown

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20244

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190404/278defa8/attachment.html>


More information about the Kde-frameworks-devel mailing list