D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

Noah Davis noreply at phabricator.kde.org
Mon Apr 1 23:36:02 BST 2019


ndavis added a comment.


  In D20166#441863 <https://phabricator.kde.org/D20166#441863>, @kossebau wrote:
  
  > IMHO the SVG files in the repo may contain comments and metadatas, for further work on them. Like source code also has all the oomments and metadata.
  >  Only the deployed graphics resource should then be limited and optimized for what is needed at runtime.
  >
  > At least I had dealt with quite some "final rendered" SVG files I would have liked to modify for some needs, but could hardly as the base resources where not available (and if it was only guides & Co.).
  
  
  I can see where you're coming from, but guides left by other people aren't that useful in my experience. I still have to guess how they made their shapes in the first place and there
  's no comment field that's visible from within Inkscape. Nobody ever puts comments in the code either. As long as you know how to use a Grid, Group/Ungroup and Combine/Break Apart, it's not hard to edit most existing icons. The few that are hard would not be improved by in-code comments or guides.
  
  In D20166#441875 <https://phabricator.kde.org/D20166#441875>, @bruns wrote:
  
  > [...] Also, stripping any whitespace makes diffs of minor changes quite large, as diffs align on lines, not tokens.
  
  
  Then we can use optimization rules that auto format and indent everything. It will expand the size of color icons a lot more than monochrome icons, but maybe we can live with that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190401/83900f01/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list