D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Mon Apr 1 21:45:10 BST 2019
bruns added a comment.
In D20166#441854 <https://phabricator.kde.org/D20166#441854>, @ndavis wrote:
> In D20166#441807 <https://phabricator.kde.org/D20166#441807>, @ngraham wrote:
>
> > Strictly speaking, there's no need to optimize the SVGs as a part of this, so maybe, yeah, let's split that out into a separate feature (and one that the Breeze Icons repo would ultimately be interested in as well).
>
>
> Yes. Ideally, designers should optimize their work before it is landed or at least not submit an SVG with tons of metadata.
On the other hand, this makes it harder for everyone else to do any changes later - think of e.g guides used for alignement. Also, stripping any whitespace makes diffs of minor changes quite large, as diffs align on lines, not tokens.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D20166
To: kossebau, #plasma, #vdg
Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190401/007c0994/attachment.html>
More information about the Kde-frameworks-devel
mailing list