<table><tr><td style="">ndavis added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20166">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D20166#441863" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D20166#441863</a>, <a href="https://phabricator.kde.org/p/kossebau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@kossebau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>IMHO the SVG files in the repo may contain comments and metadatas, for further work on them. Like source code also has all the oomments and metadata.<br />
Only the deployed graphics resource should then be limited and optimized for what is needed at runtime.</p>
<p>At least I had dealt with quite some "final rendered" SVG files I would have liked to modify for some needs, but could hardly as the base resources where not available (and if it was only guides & Co.).</p></div>
</blockquote>
<p>I can see where you're coming from, but guides left by other people aren't that useful in my experience. I still have to guess how they made their shapes in the first place and there<br />
's no comment field that's visible from within Inkscape. Nobody ever puts comments in the code either. As long as you know how to use a Grid, Group/Ungroup and Combine/Break Apart, it's not hard to edit most existing icons. The few that are hard would not be improved by in-code comments or guides.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D20166#441875" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D20166#441875</a>, <a href="https://phabricator.kde.org/p/bruns/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@bruns</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>[...] Also, stripping any whitespace makes diffs of minor changes quite large, as diffs align on lines, not tokens.</p></div>
</blockquote>
<p>Then we can use optimization rules that auto format and indent everything. It will expand the size of color icons a lot more than monochrome icons, but maybe we can live with that.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20166">https://phabricator.kde.org/D20166</a></div></div><br /><div><strong>To: </strong>kossebau, Plasma, VDG<br /><strong>Cc: </strong>bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh<br /></div>