D15814: show all borders for pop up windows in a dock

David Edmundson noreply at phabricator.kde.org
Sat Sep 29 01:09:57 BST 2018


davidedmundson added inline comments.

INLINE COMMENTS

> dialog.cpp:209
> +    QWindow *parentWindow = q->transientParent();
> +    bool inDock = parentWindow && !parentWindow->mask().isNull() && KWindowSystem::compositingActive();
> +

How does parentWindow->mask relate to being a dock or not?

Also we need to be a bit careful on names.
_NET_WM_WINDOW_TYPE_DOCK is all panels, including the standard plasma one.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180929/9ff4be21/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list