<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15814">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15814#inline-85625">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dialog.cpp:209</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QWindow</span> <span style="color: #aa2211">*</span><span class="n">parentWindow</span> <span style="color: #aa2211">=</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">transientParent</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">bool</span> <span class="n">inDock</span> <span style="color: #aa2211">=</span> <span class="n">parentWindow</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">parentWindow</span><span style="color: #aa2211">-></span><span class="n">mask</span><span class="p">().</span><span class="n">isNull</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">KWindowSystem</span><span style="color: #aa2211">::</span><span class="n">compositingActive</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">How does parentWindow->mask relate to being a dock or not?</p>

<p style="padding: 0; margin: 8px;">Also we need to be a bit careful on names.<br />
_NET_WM_WINDOW_TYPE_DOCK is all panels, including the standard plasma one.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15814">https://phabricator.kde.org/D15814</a></div></div><br /><div><strong>To: </strong>mvourlakos, Plasma, broulik, davidedmundson<br /><strong>Cc: </strong>abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns<br /></div>