D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> davidedmundson wrote in dialog.cpp:209
> How does parentWindow->mask relate to being a dock or not?
> 
> Also we need to be a bit careful on names.
> _NET_WM_WINDOW_TYPE_DOCK is all panels, including the standard plasma one.

The idea was first introduced at popupPlacement() in dialog.cpp. 
In order to distinguish docks from panels.

It is based on the assumption that by design plasma panels do not use mask() because their shadows are drawn external from the window and most of the docks (e.g. Plank,Latte) are using masking for almost all of their operations.

Do you believe there is a better way to distinguish between docks and panels ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180929/f7f1e453/attachment.html>