D16671: Refactor embedded image extractor for greater extensibility

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> embeddedimagedata.cpp:204
> +        TagLib::ByteVector pictureData = (*itApe).second.binaryData();
> +        int dataPosition = pictureData.find('\0') + 1;
> +        return QByteArray(pictureData.data() + dataPosition, pictureData.size() - dataPosition);

I know you have only moved this code here ...

`TagLib::ByteVector::find` returns `-1` on not found, and we add 1, so this is safe here. But maybe we should return `QByteArray()` instead?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16671

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181108/a881e1c3/attachment.html>