D16671: Refactor embedded image extractor for greater extensibility

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in embeddedimagedata.cpp:204
> I know you have only moved this code here ...
> 
> `TagLib::ByteVector::find` returns `-1` on not found, and we add 1, so this is safe here. But maybe we should return `QByteArray()` instead?

The code also works if only the picture data is there without the name.
I could return an empty QByteArray if dataPosition == -1 and pictureData.size == 0.
Do you prefer if I do that separately?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16671

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181110/ffd7c476/attachment.html>